Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Replace fn Offset::is_large() as const Offset::IS_LARGE #1002

Merged
merged 1 commit into from
May 21, 2022

Conversation

HaoYang670
Copy link
Contributor

@HaoYang670 HaoYang670 commented May 21, 2022

Signed-off-by: remzi 13716567376yh@gmail.com

This PR

  • Removes the inline function Offset::is_large()
  • Adds const Offset::IS_LARGE

Closes #999.

Offset::IS_LARGE can be computed at compile time, so let's do it.

Signed-off-by: remzi <13716567376yh@gmail.com>
@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #1002 (6b30828) into main (267cac0) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1002      +/-   ##
==========================================
+ Coverage   71.41%   71.42%   +0.01%     
==========================================
  Files         357      356       -1     
  Lines       19799    19783      -16     
==========================================
- Hits        14139    14130       -9     
+ Misses       5660     5653       -7     
Impacted Files Coverage Δ
src/array/binary/fmt.rs 90.90% <100.00%> (ø)
src/array/binary/mod.rs 84.46% <100.00%> (ø)
src/array/list/fmt.rs 90.90% <100.00%> (ø)
src/array/list/mod.rs 69.29% <100.00%> (ø)
src/array/list/mutable.rs 74.28% <100.00%> (ø)
src/array/utf8/fmt.rs 88.88% <100.00%> (ø)
src/array/utf8/mod.rs 70.65% <100.00%> (ø)
src/array/utf8/mutable.rs 87.23% <100.00%> (ø)
src/compute/length.rs 100.00% <100.00%> (ø)
src/scalar/binary.rs 92.85% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 267cac0...6b30828. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit f129f71 into jorgecarleitao:main May 21, 2022
@HaoYang670 HaoYang670 deleted the const_offset branch May 21, 2022 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace fn Offset::is_large() with const Offset::IS_LARGE.
2 participants